Skip to content

refactor(server): Remove unused delay-shutdown REST endpoint #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azmkercso merged 1 commit into from
Apr 20, 2026
Merged

refactor(server): Remove unused delay-shutdown REST endpoint #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/sagemaker.series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ sagemaker/display-both-versions-in-about.diff
sagemaker/validate-http-request-referer.diff
sagemaker/override-picomatch-post-startup-notifications.diff
sagemaker/sanitize-terminal-sendtext-paths.diff
sagemaker/remove-delay-shutdown-endpoint.diff
37 changes: 37 additions & 0 deletions patches/sagemaker/remove-delay-shutdown-endpoint.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
Index: code-editor-src/src/vs/server/node/remoteExtensionHostAgentServer.ts
===================================================================
--- code-editor-src.orig/src/vs/server/node/remoteExtensionHostAgentServer.ts
+++ code-editor-src/src/vs/server/node/remoteExtensionHostAgentServer.ts
@@ -158,13 +158,6 @@ class RemoteExtensionHostAgentServer ext
return void res.end(this._productService.commit || '');
}

- // Delay shutdown
- if (pathname === '/delay-shutdown') {
- this._delayShutdown();
- res.writeHead(200);
- return void res.end('OK');
- }
-
if (!httpRequestHasValidConnectionToken(this._connectionToken, req, parsedUrl)) {
// invalid connection token
return serveError(req, res, 403, `Forbidden.`);
@@ -630,18 +623,6 @@ class RemoteExtensionHostAgentServer ext
}
}

- /**
- * If the server is in a shutdown timeout, cancel it and start over
- */
- private _delayShutdown(): void {
- if (this.shutdownTimer) {
- console.log('Got delay-shutdown request while in shutdown timeout, delaying');
- this._logService.info('Got delay-shutdown request while in shutdown timeout, delaying');
- this._cancelShutdown();
- this._waitThenShutdown();
- }
- }
-
private _cancelShutdown(): void {
if (this.shutdownTimer) {
console.log('Cancelling previous shutdown timeout');
Loading