Migrate SageMaker SDK V2 to V3 in test suites#5956
Open
bhanutejagk wants to merge 6 commits intomainfrom
Open
Conversation
added 2 commits
April 16, 2026 18:37
- Replace XGBoost Estimator with ModelTrainer for training tests - Replace Model with ModelBuilder for inference tests (vLLM, SGLang, vLLM-Omni, Ray) - Update HyperparameterTuner to V3 import path and API - Update requirements to sagemaker>=3.0.0
- Fix ruff-format: json.dumps dict arg style (sglang, vllm) - Fix ruff-check F841: remove unused variable sm (vllm-omni) - Fix ruff-check F401: remove unused TransformJob import (xgboost) - Fix ruff-check isort: merge and reorder imports (xgboost) - Fix ruff-format: one-arg-per-line in _run_hpo calls (xgboost)
26f1fda to
7665eea
Compare
added 2 commits
April 17, 2026 10:48
- Change from sagemaker.serve.configs to sagemaker.serve.model_builder - Remove unused sm variable and stale comment in vllm-omni async fixture
1f9166f to
23c648a
Compare
added 2 commits
April 17, 2026 14:25
InferenceSpec is an abstract class in V3 and cannot be instantiated. Pass image_uri, env_vars, s3_model_data_url, role_arn directly to ModelBuilder instead.
…c config - Add builder.build() before every deploy() call (V3 requirement) - Update sagemaker.train.configs to sagemaker.core.training.configs - Replace async_inference_config dict with AsyncInferenceConfig object - Remove unused train_distribution parameter and caller args
fca39c5 to
b90185a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).