Skip to content

refactor: use aerial to provide outline.#1059

Merged
charliie-dev merged 8 commits intomainfrom
refactor/use-aerial
Nov 11, 2023
Merged

refactor: use aerial to provide outline.#1059
charliie-dev merged 8 commits intomainfrom
refactor/use-aerial

Conversation

@ayamir
Copy link
Owner

@ayamir ayamir commented Nov 9, 2023

Aerial.nvim has better outline support than symbols-outline.nvim. #1058 will be solved.

Signed-off-by: ayamir <lgt986452565@gmail.com>
@ayamir ayamir linked an issue Nov 9, 2023 that may be closed by this pull request
3 tasks
@ayamir
Copy link
Owner Author

ayamir commented Nov 9, 2023

image

image

@charliie-dev
Copy link
Collaborator

charliie-dev commented Nov 9, 2023

the keymaps in the aerial config doesn't seem to work.
it works, my skill issue lol

@charliie-dev
Copy link
Collaborator

charliie-dev commented Nov 9, 2023

i think aerial's telescope extension is so spot on that I think we should just change keymap:go to open it's telescope preview.
How do u think? @ayamir @Jint-lzxy
image

@Jint-lzxy
Copy link
Collaborator

also i think aerial's telescope extension is so spot on that I think we should just change keymap:go to open it's telescope preview. How do u think?

Agree, but why not assign a keymap to each of them lol

@charliie-dev
Copy link
Collaborator

charliie-dev commented Nov 9, 2023

Agree, but why not assign a keymap to each of them lol

absolutely! that would be even better!

@charliie-dev
Copy link
Collaborator

charliie-dev commented Nov 9, 2023

I think it good to go.

@Jint-lzxy
Copy link
Collaborator

Sorry I'm a bit busy with other stuff atm. I'll review this PR sometime tomorrow :D

Copy link
Collaborator

@charliie-dev charliie-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍯 but we probably need to update the relevant parts of the wiki before merging this lol

@charliie-dev charliie-dev merged commit 8b51185 into main Nov 11, 2023
@charliie-dev charliie-dev deleted the refactor/use-aerial branch November 11, 2023 06:42
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Nov 27, 2023
* refactor: use aerial to provide outline.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(aerial): update filter symbols

* chore(aerial): cleaner syntax tree

* feat(aerial): add telescope support

* fix(aerial): empty aerial telescope preview

* feat(keymap): add `gto` keymap for `:Telescope aerial`

* chore: cleanup

* chore(aerial): prune default options from setup func

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Dec 13, 2023
* refactor: use aerial to provide outline.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(aerial): update filter symbols

* chore(aerial): cleaner syntax tree

* feat(aerial): add telescope support

* fix(aerial): empty aerial telescope preview

* feat(keymap): add `gto` keymap for `:Telescope aerial`

* chore: cleanup

* chore(aerial): prune default options from setup func

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symbol outline doesn't work properly in python files and C files

3 participants