Skip to content

feat(script): skip dependency installation by default#1114

Merged
ayamir merged 1 commit intomainfrom
feat(deps)/script-more-sensible-default
Dec 25, 2023
Merged

feat(script): skip dependency installation by default#1114
ayamir merged 1 commit intomainfrom
feat(deps)/script-more-sensible-default

Conversation

@Jint-lzxy
Copy link
Collaborator

IMO the default choice for dependency installation in install.ps1 is a bit misleading (see Discussion #1106). afaik most users won't even "visit" the dynamic provider feature of Neovim, and those who know what they're doing can still continue with the dependency installation by typing Y/y. So I think a more reasonable default should be N (i.e. skipping provider installation altogether.)

IMO the default choice for dependency installation in `install.ps1`
is a bit misleading (see Discussion #1106). afaik most users won't
even "visit" the dynamic provider feature of Neovim, and those who
know what they're doing can still continue with the dependency
installation by typing `Y/y`. So I think a more reasonable default
should be `N` (i.e. skipping provider installation altogether.)
Copy link
Collaborator

@charliie-dev charliie-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@ayamir ayamir merged commit 993ee53 into main Dec 25, 2023
@ayamir ayamir deleted the feat(deps)/script-more-sensible-default branch December 25, 2023 14:40
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Dec 29, 2023
IMO the default choice for dependency installation in `install.ps1`
is a bit misleading (see Discussion ayamir#1106). afaik most users won't
even "visit" the dynamic provider feature of Neovim, and those who
know what they're doing can still continue with the dependency
installation by typing `Y/y`. So I think a more reasonable default
should be `N` (i.e. skipping provider installation altogether.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants