Skip to content

feat: search with selection text.#1175

Merged
ayamir merged 2 commits intomainfrom
feat/search-selection-text
Feb 15, 2024
Merged

feat: search with selection text.#1175
ayamir merged 2 commits intomainfrom
feat/search-selection-text

Conversation

@ayamir
Copy link
Owner

@ayamir ayamir commented Feb 13, 2024

image

Signed-off-by: ayamir <lgt986452565@gmail.com>
@ayamir ayamir requested a review from charliie-dev February 13, 2024 02:28
@charliie-dev
Copy link
Collaborator

i'll take a look when i get back to work. no pc by hand now lol.

@ayamir
Copy link
Owner Author

ayamir commented Feb 13, 2024

Wonder why the code lint was not passed. 🤨

@charliie-dev
Copy link
Collaborator

charliie-dev commented Feb 15, 2024

Wonder why the code lint was not passed. 🤨

Checking lua/keymap/tool.lua                      1 warning

    lua/keymap/tool.lua:136:56: accessing undefined variable _buf_vtext

lol

@charliie-dev
Copy link
Collaborator

functionality it works

@charliie-dev charliie-dev force-pushed the feat/search-selection-text branch from e138ca2 to b3ed6ca Compare February 15, 2024 10:08
@charliie-dev
Copy link
Collaborator

b3ed6ca (#1175)

this might do the trick lol

Copy link
Collaborator

@charliie-dev charliie-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! very useful feature lol

@ayamir ayamir merged commit ccd5eda into main Feb 15, 2024
@ayamir ayamir deleted the feat/search-selection-text branch February 15, 2024 10:24
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Feb 26, 2024
* feat: search with selection text.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(ci): ignore linting

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
misumisumi pushed a commit to misumisumi/nvimdots that referenced this pull request Mar 5, 2024
* feat: search with selection text.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(ci): ignore linting

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants