feat(catppuccin): remove all styles of @property#1240
Merged
Conversation
Based on the upstream spec, `@property` is typically associated with the "key" in key/value pairs. So IMO since we don't give special treatment to the "values" (such as assigning them an "italic" property), we should treat the "keys" in the same manner as well. Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
ayamir
approved these changes
Apr 22, 2024
jczhang02
pushed a commit
to jczhang02/nvimdots
that referenced
this pull request
May 1, 2024
Based on the upstream spec, `@property` is typically associated with the "key" in key/value pairs. So IMO since we don't give special treatment to the "values" (such as assigning them an "italic" property), we should treat the "keys" in the same manner as well. Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Deg2v
pushed a commit
to Deg2v/nvimdots
that referenced
this pull request
Jan 16, 2025
Based on the upstream spec, `@property` is typically associated with the "key" in key/value pairs. So IMO since we don't give special treatment to the "values" (such as assigning them an "italic" property), we should treat the "keys" in the same manner as well. Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the upstream spec,
@propertyis typically associated with the "key" in key/value pairs. So IMO since we don't give special treatment to the "values" (such as assigning them an "italic" property), we should treat the "keys" in the same manner as well.