feat(which-key): v3 support#1323
Closed
channinghsu wants to merge 1 commit intoayamir:mainfrom
channinghsu:main
Closed
feat(which-key): v3 support#1323channinghsu wants to merge 1 commit intoayamir:mainfrom channinghsu:main
v3 support#1323channinghsu wants to merge 1 commit intoayamir:mainfrom
channinghsu:main
Conversation
charliie-dev
approved these changes
Jul 13, 2024
v3 support
Jint-lzxy
reviewed
Jul 14, 2024
Collaborator
Jint-lzxy
left a comment
There was a problem hiding this comment.
LGTM! And u r suuuper fast lol But I kinda wanna address a few issues with regards to the new version, so I've opened another version that does the exact same thing but with some settings explicitly disabled, specifically:
- Per folke/which-key.nvim#656 (comment), I disabled
which-keyin all modes other than normal and insert mode bc imo having that popup appear every time I'm about to make a selection is remarkably annoying and a major distraction. - Disabled the built-in icon support. afaiu folke seems to have used some pattern-matching magic to detect which icon to use, but to be blunt it's buggy and doesn't cover all cases (my observations). Plus, imho it's really just another layer of distraction since we've already assigned an intuitive icon to each top-level definition.
2 tasks
Owner
|
Personally I prefer keep consistency with the old appearance. What's more, this PR seems also missing on the icons like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request updates the which-key mappings to the new specification as outlined in the documentation for version 3. The previous mappings were using the old specification, which caused warnings during the health check. The updated mappings now use the add method and are structured according to the latest guidelines.
Before:
After: