Merged
Conversation
Collaborator
|
It make sense to me to move those Don't forgot to remove this line, update |
Contributor
Author
Right, I've done. |
charliie-dev
approved these changes
Nov 4, 2024
Collaborator
charliie-dev
left a comment
charliie-dev
left a comment
There was a problem hiding this comment.
LGTM, also https://github.com/ayamir/nvimdots/wiki/Keybindings is updated.
ready to merge.
Deg2v
pushed a commit
to Deg2v/nvimdots
that referenced
this pull request
Jan 16, 2025
Jint-lzxy
added a commit
that referenced
this pull request
Jan 18, 2025
This is basically a follow-up for #1363! I combined builtin & plugin keymaps, cleaned up some comments (lol "suckless"), and made `ui.lua` export-ready Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
ayamir
pushed a commit
that referenced
this pull request
Jan 19, 2025
This is basically a follow-up for #1363! I combined builtin & plugin keymaps, cleaned up some comments (lol "suckless"), and made `ui.lua` export-ready Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put wm keymaps into
keymap/ui.luaand divided them intobuiltin_mapandplug_map. It's strightfoward and maybe you could like it.