fix(mason): add nil check to on_stderr callback in install-pylsp-plugins#1431
Merged
charliie-dev merged 1 commit intomainfrom Mar 3, 2025
Merged
fix(mason): add nil check to on_stderr callback in install-pylsp-plugins#1431charliie-dev merged 1 commit intomainfrom
charliie-dev merged 1 commit intomainfrom
Conversation
The luv doc says the on_stderr callback is also called whenever the program exits, not just when smth is written to stderr. So we should only notify if there's a real error in msg_stream. Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
3 tasks
3 tasks
Collaborator
|
@misumisumi could u check if u got time? |
Collaborator
|
works for my env too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The luv doc says the
on_stderrcallback is also called whenever the program exits, not just when smth is written to stderr. So we should only notify if there's a real error inmsg_stream.