Skip to content

fix: remove edgy.nvim to keep window size when open quickfix.#1458

Merged
charliie-dev merged 2 commits into0.11from
fix/keep-window-size
May 1, 2025
Merged

fix: remove edgy.nvim to keep window size when open quickfix.#1458
charliie-dev merged 2 commits into0.11from
fix/keep-window-size

Conversation

@ayamir
Copy link
Owner

@ayamir ayamir commented Apr 29, 2025

This PR removes edgy.nvim b/c it will disrupt the splited window size when term or sidebar openned and the nvim-bpf won't work with it. Besides, readd gto with Telescope lsp_document_symbols to find symbols.
The previous patch to prevent horizontal toggleterm from obscuring the nvim-tree will fail and cause error so I doesn't add it.

Effect comparison:

Before:

20250429-212232.1.mp4

Now:

output.mp4

@ayamir ayamir requested a review from charliie-dev April 29, 2025 12:48
@ayamir
Copy link
Owner Author

ayamir commented Apr 30, 2025

@CharlesChiuGit Please review it when you have time~

@charliie-dev
Copy link
Collaborator

sure, i will! i'll review it on this weekend~

@ayamir ayamir changed the title fix: remove edgy.nvim to keep window size when open term or sidebar. fix: remove edgy.nvim to keep window size when open quickfix. Apr 30, 2025
charliie-dev

This comment was marked as outdated.

Signed-off-by: Charles Chiu <charleschiu@hey.com>
Copy link
Collaborator

@charliie-dev charliie-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charliie-dev charliie-dev merged commit 567cff9 into 0.11 May 1, 2025
4 checks passed
@charliie-dev charliie-dev deleted the fix/keep-window-size branch May 1, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants