Skip to content

feat(scrollview): enable signs support#808

Merged
ayamir merged 1 commit intoayamir:mainfrom
Jint-lzxy:feat/scrollview-signs
Jun 19, 2023
Merged

feat(scrollview): enable signs support#808
ayamir merged 1 commit intoayamir:mainfrom
Jint-lzxy:feat/scrollview-signs

Conversation

@Jint-lzxy
Copy link
Collaborator

@Jint-lzxy Jint-lzxy commented Jun 19, 2023

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 1a4a588 into ayamir:main Jun 19, 2023
@ayamir
Copy link
Owner

ayamir commented Jun 19, 2023

Seems we can remove the signs showed on the left to simplify ui?

singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Jun 20, 2023
@Jint-lzxy Jint-lzxy deleted the feat/scrollview-signs branch June 20, 2023 12:00
@Jint-lzxy
Copy link
Collaborator Author

But the signs on RHS (or beside the scrollbar) uses relative positions (to the document), FWIW the signs showed on the left are still required for precise positioning.

bleedingfight pushed a commit to bleedingfight/nvimdots that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants