feat(dap)!: support integrated terminals (io in neovim)

[Jint-lzxy]

Recent updates to nvim-dap made integrated terminals possibe right inside Neovim. This PR implemented basic support for this feature, but it's still necessary to adjust the settings of each debugger to correctly redirect stdio to the specified terminal (inside Neovim). More info: dap-terminal.

I'm not that familiar with other debuggers so I only adjusted the settings for codelldb (AFAIK lldb-vscode has zero support for IO redirection). Someone who understands these other debuggers could help make several changes before merging :) Any help will be appreciated!

Aditionally, K (responsible for require('dapui').eval()) will be set as a buffer-local keymap (mode: n|v) when a session initiates. We may need to document this in the Wiki.

Related: #416, #440, #592

[ayamir]

It's ok for codelldb 👍

[ayamir]

Works for debugpy.

[ayamir]

delve and lldb-vscode doesn't support this feature.

mfussenegger/nvim-dap#763
mfussenegger/nvim-dap#458 (comment)

[Jint-lzxy]

@ayamir vscode-go seems to support that but this require users to compile the corresponding executables themselves.

EDIT: Just noticed that Mason has a registry entry go-debug-adapter.

[Jint-lzxy]

35ec0f0

[Jint-lzxy]

Doesn't work on my machine...

Hmmm maybe open an issue upstream at nvim-dap? I'm not that familiar with delve so probably can't help with this :

The document indicates that setting console = "integratedTerminal" is supported 🤔

[ayamir]

Doesn't work on my machine...

VSCode is ok.

[ayamir]

Hmmm maybe open an issue upstream at nvim-dap?

mfussenegger/nvim-dap#987

[charliie-dev]

sorry for the late reply, quite busy these couple weeks. i'll review this pr on following next week days.

[Jint-lzxy]

sorry for the late reply, quite busy these couple weeks. i'll review this pr on following next week days.

No worries and no hurry! Review this whenever it's convenient for you 😄

[charliie-dev]

LGTM

But I don't know how to toggle to dap terminal tho

[Jint-lzxy]

But I don't know how to toggle to dap terminal tho

@CharlesChiuGit Move ur cursor to the buffer named [dap-terminal] <profile-name> (bottom left corner), enter insert mode and use that like a normal terminal (stdin and stdout are connected to that buffer if supported)

[charliie-dev]

I only get this after I press <F6> to open terminal?

didn't see the dap-terminal buffer.

[Jint-lzxy]

didn't see the dap-terminal buffer.

Hmm that's strange. The effective component is (dapui):

{
	elements = {
		{ id = "console", size = 0.55 },
		{ id = "repl", size = 0.45 },
	},
	position = "bottom",
	size = 0.25,
},

Restart Neovim and sync those plugins to see if this helps?

[charliie-dev]

aha, I accidentally removed that part. Now it's working! tks!

[charliie-dev]

is this pr gd to go?

[Jint-lzxy]

Currently waiting for mfussenegger/nvim-dap#987, cause I'm not sure if Go-related stuffs are good to go yet.

[charliie-dev]

hmmm, the author just closed the issue as not planned.

[Jint-lzxy]

hmmm, the author just closed the issue as not planned.

Yeah that's indeed a tricky one. I'm drafting a new release note and will briefly cover this. I will merge this once Im done ;)