fix(chokidar, cli): fix orphaned child processes on intlayer watch exit#399
Merged
aymericzip merged 1 commit intoaymericzip:mainfrom Mar 21, 2026
Merged
Conversation
Use parallelProcess.kill() instead of checking for non-existent child property. Spawn with detached: true on POSIX for proper process group kill. Replace async pidtree with synchronous process group termination.
aymericzip
approved these changes
Mar 21, 2026
Owner
aymericzip
left a comment
aymericzip
left a comment
There was a problem hiding this comment.
looks good to me
thanks @modanub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
intlayer watch --with '...', Ctrl+C kills the intlayer watcher but leaves the child process (e.g. Next.js/Turbopack) running in the background.Three issues:
watch.tschecked'child' in parallelProcessto kill the child on shutdown, butParallelHandledoesn't have achildproperty — so the kill never ran. Fixed to useparallelProcess.kill().detached: true, soprocess.kill(-pid)couldn't target the process group. Fixed inspawnPosix.spawnPosixused an asyncpidtreelookup to find descendant PIDs, but the parent calledprocess.exit()before the callback fired. Replaced with synchronous process group kill.runParallelsince callers already handle shutdown.Test plan
intlayer watch --with 'exec next dev --turbopack'starts normally