fix(dictionaries-entry): use readdir for ESM/Vite compatibility#401
Merged
aymericzip merged 2 commits intoaymericzip:mainfrom Mar 22, 2026
Merged
Conversation
…or ESM compat The previous approach passed require to execute CJS entry points via vm.runInThisContext, which breaks in Vite/ESM where require is unavailable. Read JSON files directly from the dictionary output directory instead. No require(), no vm, works in both CJS and ESM environments.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #400. The
vm.runInThisContextapproach passesrequireto execute CJS entry points, which breaks in Vite/ESM environments whererequireisn't available:Replaces the CJS entry point execution with direct JSON file reading via
readdirSync+readFileSync+JSON.parse. Norequire(), novm, works in both CJS and ESM.Memory leak fix from #400 is preserved (still ~1KB/call).
Test plan
require()calls