Skip to content

Conversation

@nemophrost
Copy link
Contributor

@nemophrost nemophrost commented Apr 24, 2018

Within babel-preset-minify, if you pass an options object for one of the plugins that is disabled by default (like removeConsole) it does not get enabled.

This PR fixes that, just ensuring any plugin you are setting options for is also enabled.

@nemophrost nemophrost requested a review from boopathi as a code owner April 24, 2018 21:58
@nemophrost nemophrost changed the title Allow minify options for plugins disabled by default Allow options for plugins disabled by default (babel-preset-minify) Apr 24, 2018
Copy link
Member

@boopathi boopathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch!

@boopathi boopathi merged commit 7b17646 into babel:master May 1, 2018
@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tag: Bug Fix Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants