Fix issue #862 #863
Merged
Fix issue #862 #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
approved these changes
May 22, 2018
Member
boopathi
left a comment
boopathi
left a comment
There was a problem hiding this comment.
Looks like lint errors, You can fix it by running yarn fix
Contributor
Author
|
I'm sorry but I'm new to the Pull Request world. Is there a way to update the code so that Travis CI doesn't fail? The log says it's because of the indentation I previously mentioned. |
Member
|
Thanks! |
This was referenced Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were applied:
doesn't exist it is copied from the original source file.
P.S: I just saw that the indentation of the closing brace is wrong (Vim's fault).