Modify chromium CL flags to allow this block to be used on RPi02w#191
Open
tim-littlefair wants to merge 8 commits intobalena-io-experimental:masterfrom
Open
Modify chromium CL flags to allow this block to be used on RPi02w#191tim-littlefair wants to merge 8 commits intobalena-io-experimental:masterfrom
tim-littlefair wants to merge 8 commits intobalena-io-experimental:masterfrom
Conversation
When running on this low-resource platform, patch /home/chromium/index.html to remove <script> elements which load Bootstrap and JQuery libraries.
Modify startup scripts to ensure that chromium runs with --no-memcheck on RPiZero2W. If this flag is not specified the wrapper script /usr/bin/chromium will cause a modal dialog containing a low memory warning to be displayed - on display-only systems with no mouse/pointer device this makes the intended content to be displayed unreachable.
…ions at runtime For context see balena-io-experimental#186 (comment)
Contributor
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
Author
|
I'm not quite sure why, but the 'Commits' view of this PR lists commits which don't contribute to its actual minimal effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On RPi02W, the browser block is not in kiosk mode without and input device (mouse/pointer/keyboard) because a modal warning is displayed that the device has less memory than is recommended. Without input capability this cannot be dismissed. Even with an input device, the warning is annoying (and will be displayed twice because chromium is executed to discover the version number before running to set up the web window)
This PR modifies the start scripts to insert flag --no-memcheck into the command line on this device only.
This PR replaces #186, and is more minimal.