improve `eth_call` tests to have more real-world scenarios

[haardikk21]

our eth_call tests are fairly basic right now, simply incrementing a counter contract

in the real world the use cases are usually a bit more complex, and have led to tests not being able to catch issues that come up post-deploy

at the very least, we should have tests for:

• basic ERC-20 functionality
• ERC-20 with a TransparentProxy wrapper (e.g. USDC token)

the proxy contract with it's delegatecall behavior has some edge cases that broke this behavior on mainnet today. tests can be the exact same between both with the exception of the to field

[steph-rs]

I'd love to do it. Also, I really want to suggest some refactoring in tests area, let me know if that's okay with you

[haardikk21]

I'd love to do it. Also, I really want to suggest some refactoring in tests area, let me know if that's okay with you

Go for it!

[bbert81]

till last version balance and nonce got updated every flashblock but if i check an erc20 token balance using eth_call or eth_simulatev1 i could see that it got updated just every block. Has anything changed with the latest version?

[haardikk21]

till last version balance and nonce got updated every flashblock but if i check an erc20 token balance using eth_call or eth_simulatev1 i could see that it got updated just every block. Has anything changed with the latest version?

13.3 introduced a critical bug with eth_call that is now fixed in 13.4 please upgrade asap if using that. These tests should help catch that behavior in the future.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue was closed because it has been inactive for 5 days since being marked as stale.