Skip to content

chore(p2p): Remove P2P Crate #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danyalprout merged 2 commits into from
Jan 13, 2026
Merged

chore(p2p): Remove P2P Crate #373

danyalprout merged 2 commits into from
Jan 13, 2026

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jan 12, 2026

Summary

Removes the unused P2P crate from the workspace as it's not currently used in the base stack.

Closes #366

Changes

  • Deleted crates/builder/p2p/ directory
  • Removed P2P references from op-rbuilder:
    • Dependency in Cargo.toml
    • P2P module and message handling in flashblocks
    • CLI args (--flashblocks.p2p_*)
    • Config fields
  • Updated justfile to remove p2p from builder commands

@refcell refcell self-assigned this Jan 12, 2026
@refcell refcell added K-cleanup Kind: general cleanup A-builder Area: builder crates labels Jan 12, 2026
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 12, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@danyalprout danyalprout added this to the v0.4.0 milestone Jan 12, 2026
@refcell refcell added F-do-not-merge Flag: don't merge until this label is removed. and removed F-do-not-merge Flag: don't merge until this label is removed. labels Jan 12, 2026
@refcell refcell enabled auto-merge January 13, 2026 21:22
@refcell refcell added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@danyalprout danyalprout added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 14f4a50 Jan 13, 2026
29 checks passed
@danyalprout danyalprout deleted the rf/rm-p2p branch January 13, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danyalprout danyalprout danyalprout approved these changes

@haardikk21 haardikk21 Awaiting requested review from haardikk21

Assignees

@refcell refcell

Labels

A-builder Area: builder crates K-cleanup Kind: general cleanup

Projects

None yet

Milestone

v0.4.0

Development

Successfully merging this pull request may close these issues.

chore(workspace): Remove P2P Crate

4 participants

@refcell @cb-heimdall @danyalprout