Skip to content

Conversation

@meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 13, 2026

:shipit:

@refcell
Copy link
Contributor

refcell commented Jan 13, 2026

Screenshot 2026-01-12 at 7 39 44 PM image

@haardikk21
Copy link
Collaborator

who would be the best person to review this? i know you've been working on this stuff in diff repos. has anyone else from our team been involved or mostly just OP people?

@meyer9
Copy link
Contributor Author

meyer9 commented Jan 13, 2026

unfortunately nobody else from Base was involved. This is dependent on v1.10.0 anyway, so we can figure it out once that's merged. I think I plan on doing a few somewhat reviewable commits:

  1. Copy in code from their repo (maybe possible to preserve Git history)
    a. This is all well-reviewed and tested.
  2. Update their code with a few small changes required to work with upstream Reth (should be reviewed by us)
  3. Glue code to work with our extension system (should be reviewed by us)
  4. Remove unnecessary code like some of their RPC/ExEx stuff (very straightforward - check unused and remove)
  5. Formatting fixes

I don't think submodules will work since we have to apply some fixes to get it working with upstream Reth. I don't think importing as a crate will work because then we're stuck with their version of Reth and dependent on them updating.

@refcell
Copy link
Contributor

refcell commented Jan 13, 2026

I'm happy to give it thorough review when desired.

I would also +1 on advising against submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants