refactor(builder): replace custom Signer with Alloy's PrivateKeySigner #426
+115
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
refcell
reviewed
Jan 13, 2026
| >, | ||
| ) -> Self { | ||
| let base_builder_tx = BuilderTxBase::new(Some(signer)); | ||
| let base_builder_tx = BuilderTxBase::new(Some(signer.clone())); |
Contributor
There was a problem hiding this comment.
Not a huge fan of the .clone()s but it's not a big deal.
refcell
approved these changes
Jan 13, 2026
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
This looks good to me, would appreciate a second pair of eyes though.
Collaborator
|
Review Error for refcell @ 2026-01-13 23:09:39 UTC |
Replace the custom secp256k1-based Signer implementation with Alloy's PrivateKeySigner. This simplifies the codebase by reusing well-tested cryptographic primitives from the alloy-signer crate. Changes: - Wrap PrivateKeySigner in Signer struct with cached address field - Update sign_message to use SignerSync::sign_hash_sync - Update sign_tx to use eyre::Result instead of secp256k1::Error - Remove secp256k1 direct dependencies from tx_signer module - Update test files to use .clone() where Signer is moved Closes base#390
Himess
force-pushed
the
refactor/replace-custom-signer-with-alloy
branch
from
1bd7a11 to
06fee44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #390