chore(builder): simplify op-rbuilder test framework #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add builder tests and clippy to main ci target - Remove redundant ci-builder target Closes base#444
Remove the rb_test proc-macro crate and replace with simple tokio::test. Since only flashblocks variant remains, the macro templating is no longer needed. - Replace #[rb_test] with #[tokio::test] in all test files - Add setup_test_instance() helper functions to framework/mod.rs - Remove if_standard! and if_flashblocks! conditional macros - Delete the macros crate entirely Closes base#445
Collaborator
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
rb_testproc-macrocrate and replace with simpletokio::test.Since only flashblocks variant remains, the macro templating is no longer needed.
#[rb_test]with#[tokio::test]in all test filessetup_test_instance()helper functions to framework/mod.rsif_standard!andif_flashblocks!conditional macrosCloses #445