fix: don't include e2e/smoke bazeliskrc on bcr ci runs#651
Closed
kormide wants to merge 1 commit intobazel-contrib:mainfrom
Closed
fix: don't include e2e/smoke bazeliskrc on bcr ci runs#651kormide wants to merge 1 commit intobazel-contrib:mainfrom
kormide wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
kormide
commented
Nov 14, 2023
| # 1. In .bcr/presubmit.yml, override the env vars BAZELISK_BASE_URL and USE_BAZEL_VERSION | ||
| # 2. Add a Publish To BCR patch under .bcr/patches to remove the file. Worked on the BCR CI | ||
| # on all platforms except for OSX where the patch command failed. | ||
| rm ./e2e/smoke/.bazeliskrc |
Collaborator
Author
There was a problem hiding this comment.
No, this won't work. It won't be included in the archive command below which references the tag..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed in #622. Now that we create e2e/smoke/.bazeliskrc, the bazel central registry ci fails when we push a release because there we don't publish cli windows binaries. Remove the file from the release archive altogether.
Type of change