fix: exclude bazeliskrc from smoke test#654
Merged
kormide merged 1 commit intobazel-contrib:mainfrom Nov 14, 2023
Merged
Conversation
alexeagle
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed in #622. The addition of e2e/smoke/.bazeliskrc causes the BCR ci to fail. It seems to have difficulty loading the root bazelrc from this symlinked file under Windows. The solution here is to just leave it out of the release archive. The purpose of the bazeliskrc file here is to use the Aspect CLI on our own ci, but we don't need to use it on the BCR.
Type of change