Make cc_host_compile_flags configurable#461
Merged
cloudhan merged 1 commit intobazel-contrib:mainfrom Feb 26, 2026
Merged
Conversation
Contributor
Author
cloudhan
reviewed
Feb 24, 2026
cuda/private/cuda_helper.bzl
Outdated
Comment on lines
295
to
298
| flags_to_skip = ctx.attr._cc_host_compile_flags_to_skip[BuildSettingInfo].value | ||
|
|
||
| if cuda_toolchain.toolchain_identifier == "clang": | ||
| flags_to_skip.append( | ||
| "-fno-canonical-system-headers", | ||
| ) | ||
| flags_to_skip.append("-fno-canonical-system-headers") |
Collaborator
There was a problem hiding this comment.
@hofbi builtin containers from attr are immutable, you need to convert them to list first before append.
Contributor
There was a problem hiding this comment.
base = ctx.attr._cc_host_compile_flags_to_skip[BuildSettingInfo].value
extra = ["-fno-canonical-system-headers"] if cuda_toolchain.toolchain_identifier == "clang" else []
flags_to_skip = list(base) + extra
Perhaps something like this?
hofbi
commented
Feb 24, 2026
hofbi
force-pushed
the
configure-host-compile-flags-to-skip
branch
from
5f4b330 to
a5893c5
Compare
Contributor
Author
|
Not sure if https://github.com/bazel-contrib/rules_cuda/actions/runs/22439080161/job/64976494917 is related to the PR changes |
Contributor
Unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending #419. Depending on which compiler you are using, some flags should be skipped. This PR makes the
flags_to_skiphardcoded in #419 configurable via the command line.