Add embedded jdk support for ppc64le#11436
Closed
jayfurmanek wants to merge 5 commits intobazelbuild:masterfrom
Closed
Add embedded jdk support for ppc64le#11436jayfurmanek wants to merge 5 commits intobazelbuild:masterfrom
jayfurmanek wants to merge 5 commits intobazelbuild:masterfrom
Conversation
aiuto
added
the
team-OSS
philwo
suggested changes
May 19, 2020
Member
philwo
left a comment
philwo
left a comment
There was a problem hiding this comment.
This is really cool! Thank you :)
The tests fail, but the fix is simple (there's just a wrong URL in the jdk.WORKSPACE).
src/main/java/com/google/devtools/build/lib/bazel/rules/java/jdk.WORKSPACE
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/rules/java/jdk.WORKSPACE
Outdated
Show resolved
Hide resolved
Member
|
FYI @meisterT |
Member
|
Nice! |
Contributor
Author
|
I think the remaining fails here are unrelated. Also, what's the policy on compile.sh changes? In our builds, we add in the below to the bazel build command: It looks like it doesn't build in the jdk by default. Is the idea that you should do that kind of thing with a bazelrc file? Thanks for reviewing! |
Member
To be honest, I'm not sure what these flags do. 😬 Why do you need them for your build? The test failures are indeed related to this change: They happen because we run most tests without network access on our CI and instead inject the external repositories (like JDKs) from the outside. It should work if you copy the definition of your Then add your
That should fix it. :) |
Contributor
Author
|
That worked. Thanks for the assistance @philwo ! |
meisterT
approved these changes
May 20, 2020
Contributor
Author
|
Anything else needed here? Thx!! |
Member
|
@jayfurmanek I think we're good, thanks! I'll try to merge this now. |
philwo
approved these changes
May 28, 2020
ruixin-bao
pushed a commit
to linux-on-ibm-z/bazel
that referenced
this pull request
Jul 27, 2020
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel for s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website. Another thing this PR does is to also provide the cached version of allmodules_jdk and minimal_jdk zip files built on s390x. I have tested by linking this file locally on s390x machines and with these zip files provided, tests no longer fail with java exec format error on s390x.
ruixin-bao
pushed a commit
to linux-on-ibm-z/bazel
that referenced
this pull request
Jul 27, 2020
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel on s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website. Another thing this PR does is to provide the cached version of allmodules_jdk and minimal_jdk zip files built on s390x. I have tested by linking the files locally on s390x and with these zip files provided, tests no longer fail with java exec format error on s390x.
ruixin-bao
pushed a commit
to linux-on-ibm-z/bazel
that referenced
this pull request
Jul 27, 2020
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel on s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website. Another thing this PR does is to provide the cached version of allmodules_jdk and minimal_jdk zip files built on s390x. I have tested by linking the files locally on s390x and with these zip files provided, tests no longer fail with java exec format error on s390x.
ruixin-bao
pushed a commit
to linux-on-ibm-z/bazel
that referenced
this pull request
Aug 14, 2020
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel on s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website.
ruixin-bao
pushed a commit
to linux-on-ibm-z/bazel
that referenced
this pull request
Aug 14, 2020
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel on s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website.
ruixin-bao
pushed a commit
to linux-on-ibm-z/bazel
that referenced
this pull request
Aug 18, 2020
This patch follows a similar approach used in PR bazelbuild#11436 to add support for embedding OpenJDK in bazel on s390x. Similar to ppc, the openjdk used will be downloadded from adoptopenjdk website.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for embedding OpenJDK in bazel for ppc64le.
Azul Systems does not create Zulu/OpenJDK builds for ppc64le, but AdoptOpenjdk.net does.
This PR adds the necessary configs and conditionals and http_file configuration URLs for adoptopenjdk downloads.
The minimize_jdk.sh script needed a slight generalization.
I've been using adoptOpenjdk-embedded bazel for quite a while and can vouch for its stability.