Add unit test against released java_tools_javac14#11828
Closed
davido wants to merge 1 commit intobazelbuild:masterfrom
Closed
Add unit test against released java_tools_javac14#11828davido wants to merge 1 commit intobazelbuild:masterfrom
davido wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
Closes bazelbuild#11017. This is the follow-up for PR: [1]. Because of the chicken and the egg problem, it has to be done in three steps: 1. add support for java toolchange JDK 14, done in: [1] 2. publish new java_tools_javac14, kicked off by the pipeline in java_tools repository, in context of: [2] 3. add unit test against released java_tools_javac14 published in step 2, this change Test Plan: $ bazel test //src/test/shell/bazel:bazel_coverage_java_jdk14toolchain_released_test [1] bazelbuild#11514 [2] bazelbuild/java_tools#28
davido
force-pushed
the
add_test_for_java_tools_javac14
branch
from
870a678 to
57cbb94
Compare
comius
approved these changes
Jul 24, 2020
Contributor
Author
ehkloaj
pushed a commit
to ehkloaj/bazel
that referenced
this pull request
Aug 6, 2020
Closes bazelbuild#11017. This is the follow-up for PR: [1]. Because of the chicken and the egg problem, it has to be done in three steps: 1. add support for java toolchange JDK 14, done in: [1] 2. publish new java_tools_javac14, kicked off by the pipeline in java_tools repository, in context of: [2] 3. add unit test against released java_tools_javac14 published in step 2, this change Test Plan: $ bazel test //src/test/shell/bazel:bazel_coverage_java_jdk14toolchain_released_test [1] bazelbuild#11514 [2] bazelbuild/java_tools#28 Closes bazelbuild#11828. PiperOrigin-RevId: 324358602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11017.
This is the follow-up for PR: [1]. Because of the chicken and the egg
problem, it has to be done in three steps:
java_tools repository, in context of: [2]
this change
Test Plan:
$ bazel test //src/test/shell/bazel:bazel_coverage_java_jdk14toolchain_released_test
[1] #11514
[2] bazelbuild/java_tools#28