Skip to content

Add supplemental support for JDK 11, 17 and 19 on cpu s390x#17382

Closed
kun-lu20 wants to merge 4 commits intobazelbuild:masterfrom
linux-on-ibm-z:add_supplemental_support_for_jdk_versions_on_s390x
Closed

Add supplemental support for JDK 11, 17 and 19 on cpu s390x#17382
kun-lu20 wants to merge 4 commits intobazelbuild:masterfrom
linux-on-ibm-z:add_supplemental_support_for_jdk_versions_on_s390x

Conversation

@kun-lu20
Copy link
Contributor

@kun-lu20 kun-lu20 commented Feb 1, 2023

Recent releases of Bazel have already supported JDK 11 and 17 on cpu s390x. This PR aims to add support for JDK 18 and supplement the support for JDK 11 and 17 on cpu s390x.

The code changes have been verified on s390x and won't cause any regressions on other archs.

Fixes #17381 .

commit 19b2e2f has replaced JDK 18 with JDK 19, so this PR was updated as well to add support for JDK 19 on s390x.

Signed-off-by: Kun-Lu kun.lu@ibm.com

Signed-off-by: Kun-Lu <kun.lu@ibm.com>
@kun-lu20 kun-lu20 changed the title Add supplemental support for JDK 11, 17 and 18 on s390x Add supplemental support for JDK 11, 17 and 18 on cpu s390x Feb 1, 2023
@ShreeM01 ShreeM01 added awaiting-user-response Awaiting a response from the author team-Rules-Java Issues for Java rules labels Feb 2, 2023
@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Feb 3, 2023

Hi @kshyanashree ,

I think the test failures in PR presubmit checks are not related to this PR. Could you please change awaiting-user-response tag to awaiting-review?

Thanks!

@ShreeM01 ShreeM01 added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Feb 3, 2023
@ShreeM01
Copy link
Contributor

ShreeM01 commented Feb 3, 2023

Hi @kshyanashree ,

I think the test failures in PR presubmit checks are not related to this PR. Could you please change awaiting-user-response tag to awaiting-review?

Thanks!

sure, Done!

@ShreeM01
Copy link
Contributor

ShreeM01 commented Feb 3, 2023

Hi @kshyanashree ,
I think the test failures in PR presubmit checks are not related to this PR. Could you please change awaiting-user-response tag to awaiting-review?
Thanks!

Sure, done!

@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Feb 8, 2023

Hi @kshyanashree ,

Could you please help to assign someone to review this PR?

Thank you very much!

@kun-lu20
Copy link
Contributor Author

Hi @kshyanashree ,

Could you please review this PR?

Thank you!

@ShreeM01 ShreeM01 requested a review from hvadehra February 13, 2023 18:22
@hvadehra
Copy link
Member

Hi @kun-lu20 , this looks fine to me, but we currently don't have any way to test such changes.

In the earlier change that added the embedded jdk11 for s390x, it was mentioned that it may be possible to have access to a VM for testing. Is this still a possibility?

@kun-lu20
Copy link
Contributor Author

Hi @hvadehra ,

Thanks for reviewing this PR!

Yes, for sure we can provide s390x VMs for testing. Let me check the latest process for requesting VMs and I'll get back to you later.

@kun-lu20
Copy link
Contributor Author

Hi @hvadehra ,

Please use the following form to request s390x VMs for testing: https://www.ibm.com/community/z/open-source/virtual-machines-request/ . Feel free to let me know if you run into any problems.

Thank you very much!

…on_s390x

Signed-off-by: Kun-Lu <kun.lu@ibm.com>
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
@kun-lu20 kun-lu20 changed the title Add supplemental support for JDK 11, 17 and 18 on cpu s390x Add supplemental support for JDK 11, 17 and 19 on cpu s390x Feb 27, 2023
@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Feb 27, 2023

Hi @hvadehra ,

Recent commits on this PR solves the conflicts from master branch and replaces the support for JDK 18 with JDK 19 on s390x as per the change introduced by commit 19b2e2f. Please take a look when you have a chance.

Although some PR checks failed because OpenJDK19U-jdk_s390x_linux_hotspot_19.0.2_7.tar.gz or rules_license-0.0.3.tar.gz couldn't be downloaded, the downloading worked fine on our local s390x VMs and the build completed successfully.

Also please feel free to let me know if there is anything I can help with the s390x VMs request.

Thank you very much!

@hvadehra
Copy link
Member

hvadehra commented Mar 1, 2023

Hi, I've gotten the account and created an instance. I will spend some time today setting it up and testing this PR.

@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Mar 1, 2023

Thank you very much @hvadehra !

@comius
Copy link
Contributor

comius commented Mar 3, 2023

Hey @kun-lu20, because bzlmod uses rules_java, could you also update it here: https://github.com/bazelbuild/rules_java/blob/master/java/repositories.bzl

@copybara-service copybara-service bot closed this in 66f571e Mar 3, 2023
@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Mar 3, 2023

Hi @comius ,

Yes sure, I'll raise a PR in bazelbuild/rules_java to update it.

Thanks!

fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Recent releases of Bazel have already supported JDK 11 and 17 on cpu s390x. This PR aims to add support for JDK 18 and supplement the support for JDK 11 and 17 on cpu s390x.

The code changes have been verified on s390x and won't cause any regressions on other archs.

Fixes bazelbuild#17381 .

commit bazelbuild@19b2e2f has replaced JDK 18 with JDK 19, so this PR was updated as well to add support for JDK 19 on s390x.

Signed-off-by: Kun-Lu <kun.lu@ibm.com>

Closes bazelbuild#17382.

PiperOrigin-RevId: 513741650
Change-Id: I0c5d8406900b0568e95f4f471d66fe9ad1dab57c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for JDK 18 on cpu s390x

4 participants