Add supplemental support for JDK 11, 17 and 19 on cpu s390x#17382
Add supplemental support for JDK 11, 17 and 19 on cpu s390x#17382kun-lu20 wants to merge 4 commits intobazelbuild:masterfrom
Conversation
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
|
Hi @kshyanashree , I think the test failures in PR Thanks! |
sure, Done! |
|
|
Hi @kshyanashree , Could you please help to assign someone to review this PR? Thank you very much! |
|
Hi @kshyanashree , Could you please review this PR? Thank you! |
|
Hi @kun-lu20 , this looks fine to me, but we currently don't have any way to test such changes. In the earlier change that added the embedded jdk11 for s390x, it was mentioned that it may be possible to have access to a VM for testing. Is this still a possibility? |
|
Hi @hvadehra , Thanks for reviewing this PR! Yes, for sure we can provide s390x VMs for testing. Let me check the latest process for requesting VMs and I'll get back to you later. |
|
Hi @hvadehra , Please use the following form to request s390x VMs for testing: https://www.ibm.com/community/z/open-source/virtual-machines-request/ . Feel free to let me know if you run into any problems. Thank you very much! |
…on_s390x Signed-off-by: Kun-Lu <kun.lu@ibm.com>
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
|
Hi @hvadehra , Recent commits on this PR solves the conflicts from master branch and replaces the support for JDK 18 with JDK 19 on s390x as per the change introduced by commit 19b2e2f. Please take a look when you have a chance. Although some PR checks failed because Also please feel free to let me know if there is anything I can help with the s390x VMs request. Thank you very much! |
|
Hi, I've gotten the account and created an instance. I will spend some time today setting it up and testing this PR. |
|
Thank you very much @hvadehra ! |
|
Hey @kun-lu20, because bzlmod uses rules_java, could you also update it here: https://github.com/bazelbuild/rules_java/blob/master/java/repositories.bzl |
|
Hi @comius , Yes sure, I'll raise a PR in bazelbuild/rules_java to update it. Thanks! |
Recent releases of Bazel have already supported JDK 11 and 17 on cpu s390x. This PR aims to add support for JDK 18 and supplement the support for JDK 11 and 17 on cpu s390x. The code changes have been verified on s390x and won't cause any regressions on other archs. Fixes bazelbuild#17381 . commit bazelbuild@19b2e2f has replaced JDK 18 with JDK 19, so this PR was updated as well to add support for JDK 19 on s390x. Signed-off-by: Kun-Lu <kun.lu@ibm.com> Closes bazelbuild#17382. PiperOrigin-RevId: 513741650 Change-Id: I0c5d8406900b0568e95f4f471d66fe9ad1dab57c
Recent releases of Bazel have already supported JDK 11 and 17 on cpu s390x. This PR aims to add support for JDK 18 and supplement the support for JDK 11 and 17 on cpu s390x.
The code changes have been verified on s390x and won't cause any regressions on other archs.
Fixes #17381 .
commit 19b2e2f has replaced JDK 18 with JDK 19, so this PR was updated as well to add support for JDK 19 on s390x.
Signed-off-by: Kun-Lu kun.lu@ibm.com