Fix accidental variable shadowing that broke version resolution.#186
Merged
fweikert merged 3 commits intobazelbuild:masterfrom Oct 16, 2020
Merged
Fix accidental variable shadowing that broke version resolution.#186fweikert merged 3 commits intobazelbuild:masterfrom
fweikert merged 3 commits intobazelbuild:masterfrom
Conversation
Member
|
Is there a way to add a simple test for this? |
philwo
approved these changes
Oct 16, 2020
Member
philwo
left a comment
philwo
left a comment
There was a problem hiding this comment.
These are the moments where I think maybe using Go wasn't that great of an idea... 🤯
Thanks for fixing it!
Member
Author
|
One problem is that we don't use single-assignment form for resolvedBazelVersion. We do have internal readability advice for Python that advocates for single-assignment form. |
There are some other problems with the test, and I don't want to block the fix on it (given that the entire --migrate feature has been untested forever). I tested the fix locally.
Member
Author
|
Filed #187 for test coverage |
Member
|
Please tell me when a new release is available, then I can help update the Windows image |
Member
|
Just manually tested this on Windows, it did fix the issue! |
Member
Author
|
Thanks for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #185