Skip to content

Conversation

@copybara-service
Copy link

@copybara-service copybara-service bot commented Feb 5, 2021

[2020.3 compat] remove obsolete StatementParsing.FUTURE flag from sdkcompat

The flag is nonexistent in the sdk for 2020.3. The flag has been used previously for Python 2.6 support of __future__ imports of print_function but is obsolete since 2.6 support has been dropped since 2019.1

For reasons of having a simple implementation of compatibility with old sdks and reducing the maintenance burden we chose to pass the StatementParsing.FUTURE as null for versions < 203.

@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@copybara-service copybara-service bot force-pushed the test_355938588 branch 7 times, most recently from cf955a6 to ce01209 Compare February 17, 2021 10:50
…dkcompat

The flag is nonexistent in the sdk for 2020.3. The flag has been used previously for Python 2.6 support of `__future__` imports of `print_function` but [is obsolete](JetBrains/intellij-community@7ec52fb) since 2.6 support has been dropped [since 2019.1](https://github.com/JetBrains/intellij-community/blob/a251e6a423baa93fc6fd85038ec9ccec63fc2797/python/python-psi-api/src/com/jetbrains/python/psi/LanguageLevel.java)

For reasons of having a simple implementation of compatibility with old sdks and reducing the maintenance burden we chose to pass the StatementParsing.FUTURE as null for versions < 203.

PiperOrigin-RevId: 357909336
@copybara-service copybara-service bot merged commit f1c5601 into master Feb 17, 2021
@copybara-service copybara-service bot deleted the test_355938588 branch February 17, 2021 10:54
@alice-ks alice-ks mentioned this pull request May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants