Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bdzicc
when testing I noticed some unwanted behavior in the checkbox, check the pr I did in your repository,
I noticed that you use getText to know if you're currently in skipquick or lootquick, with the function
modules.game_quickloot.QuickLoot.data.filterit's easier to determine.Also, I made an optimization. I found it unnecessary to have two checkboxes stacked on top of each other, so I used a single function. If you look closely in your pr , they are the same.
the only difference is the number, which is
modules.game_quickloot.QuickLoot.data.filterbandicam.2025-02-28.15-36-57-265.mp4