Add early return to Redis watcher in case of MGET error to avoid panicking#91
Merged
mantzas merged 1 commit intobeatlabs:masterfrom Jun 17, 2021
Merged
Conversation
sgarcez
approved these changes
Jun 17, 2021
aziule
approved these changes
Jun 17, 2021
mantzas
approved these changes
Jun 17, 2021
Lazaros-Tsigkakos
approved these changes
Jun 17, 2021
c0nstantx
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In case of MGET error current implementation still expects resulting values array to have the same length as keys array, tries to iterave over them and panicks with:
Short description of the changes
Add an early return in case of error.