Resource leak issue fixed and added IDE files to .gitignore#3
Merged
becheran merged 1 commit intobecheran:mainfrom Jan 31, 2023
Merged
Resource leak issue fixed and added IDE files to .gitignore#3becheran merged 1 commit intobecheran:mainfrom
becheran merged 1 commit intobecheran:mainfrom
Conversation
becheran
approved these changes
Jan 31, 2023
Owner
becheran
left a comment
becheran
left a comment
There was a problem hiding this comment.
Thanks for fixing! Definitely a 🐛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Resource Leak
Problem
The resource leak in the code caused by improper use of defer statement in client function was causing significant performance degradation and was affecting the stability of the system.
Solution
The solution involved identifying and addressing the source of the leak and refactored the close method. The following changes were made:
The changes were tested in the following ways:
Verified that the resource leak no longer occurs by running the code under heavy load
Impact
The changes should have no negative impact on the rest of the code base or any dependencies. The improved memory management should result in improved performance and stability.
Mentions
@reviewers Please review these changes and let me know if there are any further updates or changes needed. Thank you!