feat: support reordering modifers with a leading comment#1786
Merged
belav merged 2 commits intobelav:mainfrom Dec 19, 2025
Merged
feat: support reordering modifers with a leading comment#1786belav merged 2 commits intobelav:mainfrom
belav merged 2 commits intobelav:mainfrom
Conversation
TimothyMakkison
force-pushed
the
leading_modifier
branch
from
a6a7809 to
031e37f
Compare
Contributor
Author
|
Changed the logic for assigning leading trivia because it would always trigger the |
TimothyMakkison
force-pushed
the
leading_modifier
branch
from
031e37f to
ccaf778
Compare
TimothyMakkison
force-pushed
the
leading_modifier
branch
from
ccaf778 to
c9bf50d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1784
It might be possible reorder all modiferes with comments and keep this logic. Perhaps this breaks something 🤷