Adding MSBuild support for transitive and multi-target scenarios#1834
Merged
belav merged 4 commits intobelav:mainfrom Mar 26, 2026
Merged
Adding MSBuild support for transitive and multi-target scenarios#1834belav merged 4 commits intobelav:mainfrom
belav merged 4 commits intobelav:mainfrom
Conversation
belav
requested changes
Mar 22, 2026
Owner
belav
left a comment
belav
left a comment
There was a problem hiding this comment.
I fixed the unrelated warning on main and got that merged into here.
Could you fix the formatting or see if my comment about pulling in the existing folders works?
Thanks!
Comment on lines
+24
to
+25
| <Content Include="buildMultiTarget/*" PackagePath="buildMultiTarget/" /> | ||
| <Content Include="buildTransitive/*" PackagePath="buildTransitive/" /> |
Owner
There was a problem hiding this comment.
I was gonna approve and merge as is, but because this failed formatting checks I'm curious.
Could this instead just pull the existing files into those paths? It seems like this may work without needing the 4 new files. Either way is fine with me, I don't expect to be adding any new files to those folders.
<Content Include="build/*" PackagePath="buildMultiTarget/" />
<Content Include="build/*" PackagePath="buildTransitive/" />
Contributor
Author
There was a problem hiding this comment.
Yeah, that's perfectly okay. Just wasn't sure if you wanted a least a little separation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding
buildTransitiveandbuildMultiTargetso CSharpier can still work as a transitive dependency.Related Issue
Fixes: #1833
Checklist
varthis.