Skip to content

Simplify logic of from(unsigned) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
z-tech merged 2 commits into from
Nov 11, 2025
Merged

Simplify logic of from(unsigned) #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dd67b3
chkpt
z-tech Nov 11, 2025
63589c5
depend on from(u128), from(u128) should reduce
z-tech Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions ff/src/fields/models/small_fp/from.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ use crate::{BigInt, PrimeField};

impl<P: SmallFpConfig> From<u128> for SmallFp<P> {
fn from(other: u128) -> Self {
let bigint = BigInt::<2>::new([other as u64, (other >> 64) as u64]);
let reduced_other = other % P::MODULUS_U128;
let bigint = BigInt::<2>::new([reduced_other as u64, (reduced_other >> 64) as u64]);
Self::from_bigint(bigint).unwrap()
}
}
Expand Down Expand Up @@ -65,16 +66,7 @@ impl<P: SmallFpConfig> From<i32> for SmallFp<P> {

impl<P: SmallFpConfig> From<u16> for SmallFp<P> {
fn from(other: u16) -> Self {
let other_as_t = match P::T::try_from(other.into()) {
Ok(val) => val,
Err(_) => {
let modulus_as_u128: u128 = P::MODULUS.into();
let reduced = (other as u128) % modulus_as_u128;
P::T::try_from(reduced).unwrap_or_else(|_| panic!("Reduced value should fit in T"))
},
};
let val = other_as_t % P::MODULUS;
SmallFp::new(val)
Self::from(other as u128)
}
}

Expand All @@ -91,16 +83,7 @@ impl<P: SmallFpConfig> From<i16> for SmallFp<P> {

impl<P: SmallFpConfig> From<u8> for SmallFp<P> {
fn from(other: u8) -> Self {
let other_as_t = match P::T::try_from(other.into()) {
Ok(val) => val,
Err(_) => {
let modulus_as_u128: u128 = P::MODULUS.into();
let reduced = (other as u128) % modulus_as_u128;
P::T::try_from(reduced).unwrap_or_else(|_| panic!("Reduced value should fit in T"))
},
};
let val = other_as_t % P::MODULUS;
SmallFp::new(val)
Self::from(other as u128)
}
}

Expand Down