Manifold reduction extremity scale shouldn't redundantly include epsilon scale#382
Merged
RossNordby merged 2 commits intomasterfrom Sep 2, 2025
Merged
Manifold reduction extremity scale shouldn't redundantly include epsilon scale#382RossNordby merged 2 commits intomasterfrom
RossNordby merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extremity of a manifold is already in the same units and of comparable scale to the depth; including the
epsilonScalejust doubles up and introduces subtle instability at extreme scales.Specifically, you can see a wee bit of contact churn if you enable contact visualization on the new test demo when using
epsilonScale, but not with the fix.h/t @erincatto for the dimensional analysis squinting!