Conversation
service.toml
Outdated
| optional = ["offset", "io_callback", "size", "file_version"] | ||
|
|
||
| [namespace.storage.op.stat] | ||
| optional = ["file_version", "object_type"] |
There was a problem hiding this comment.
ditto.
And we have ObjectMode, object_type is not needed.
There was a problem hiding this comment.
I couldn't found ObjectMode in stat ops, where should I found?
I separate these two types because different object type need different operations in minio-client, and stat to a folder object may cost more time.
There was a problem hiding this comment.
GSP-93 has been approved, we can use ObjectMode in stat now.
minio doesn't have native support for DirObject, so we need to simulate it. Let's implement in another PR.
For current PR, It's OK to implement just like no dir object exists.
And in next PR, we need to:
- Implement CreateDir with
simulate = true(described in GSP-87) - Implement Stat / Delete a dir object.
NOTICE: go-storage requires zero-cost abstraction. so we can't use ListObjects API in stat.
timber-joan
force-pushed
the
basicImplement
branch
from
e8dcb99 to
1ee2362
Compare
timber-joan
force-pushed
the
basicImplement
branch
from
1ee2362 to
5d6992d
Compare
|
In order to make builds pass, we need to change |
|
@timber-joan Thank you very much for your hard work and dedication, but PR #6 has been merged, so we had to close this PR. Hope to see your contribution again sometime! |
2 participants
Implement basic Storager functions.
Update related confs.
Passed all go test.
