Conversation
Bumps [github.com/beyondstorage/go-integration-test/v4](https://github.com/beyondstorage/go-integration-test) from 4.1.1 to 4.2.0. - [Release notes](https://github.com/beyondstorage/go-integration-test/releases) - [Changelog](https://github.com/beyondstorage/go-integration-test/blob/master/CHANGELOG.md) - [Commits](beyondstorage/go-integration-test@v4.1.1...v4.2.0) --- updated-dependencies: - dependency-name: github.com/beyondstorage/go-integration-test/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: xxchan <37948597+xxchan@users.noreply.github.com>
| options = append(options, oss.ServerSideEncryptionKeyID(opt.ServerSideEncryptionKeyID)) | ||
| } | ||
|
|
||
| offset, err := s.bucket.AppendObject(rp, nil, 0, options...) |
There was a problem hiding this comment.
This API call is removed (so won't create an empty object?). Is this expected?
There was a problem hiding this comment.
There was a problem hiding this comment.
The original intention of creating an empty object in CreateAppend is to set the object system metadata at the first append request. You can refer here for more details.
Actually there's no requirement to create an empty object for CreateAppend, so I removed the API call to reduce a request.
There was a problem hiding this comment.
The discussion says that if we cannot create an empty object, we use metadata.
You mean that we can simply use metadata? This LGTM, but I'm not sure if there is further consideration.
There was a problem hiding this comment.
You mean that we can simply use metadata? This LGTM, but I'm not sure if there is further consideration.
I'm not sure whether we should ensoure that the object can be retrieved from server after CreateAppend. Or just create an appendable Object for users to call WriteAppend?
There was a problem hiding this comment.
I'm not sure whether we should ensoure that the object can be retrieved from server after
CreateAppend. Or just create an appendableObjectfor users to callWriteAppend?
I think it's not safe. For example, user call CreateAppend() but failed on next WriteAppend call. So, it's impossible for him to Stat() and resume the append process.
There was a problem hiding this comment.
Got it. I'll change back to create an empty object in CreateAppend.
storage.go
Outdated
| if err != nil { | ||
| return | ||
| } | ||
| } else { |
There was a problem hiding this comment.
We shouldn't have else here? (if exist, delete and then create)
3 participants
No description provided.