Skip to content

Fix the precompiles on Julia 1.3+#59

Open
timholy wants to merge 1 commit intobicycle1885:masterfrom
timholy:teh/precompile
Open

Fix the precompiles on Julia 1.3+#59
timholy wants to merge 1 commit intobicycle1885:masterfrom
timholy:teh/precompile

Conversation

@timholy
Copy link

@timholy timholy commented Nov 29, 2019

Fixes #58. This was autogenerated by SnoopCompile 1.0, which puts anonymous functions inside an isdefined check.

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #59 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage    86.3%   86.26%   -0.04%     
==========================================
  Files           5        5              
  Lines        1066     1063       -3     
==========================================
- Hits          920      917       -3     
  Misses        146      146
Impacted Files Coverage Δ
src/TableReader.jl 91.74% <100%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a39c2...0f140e0. Read the comment docs.

@timholy
Copy link
Author

timholy commented Dec 1, 2019

For some strange reason one of the Travis tests is still marked "pending," but if you click on Details you'll see it finished a long time ago.

Once this gets merged you probably want to tag a new release, since currently TableReader doesn't even load on the stable version of Julia.

@ghost
Copy link

ghost commented Mar 25, 2020

Might this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableReader precompilation fails on 1.3.0-rc3 on Windows

2 participants