PROMO-1393 add number of codes use #1237
Conversation
add number of codes use fields
| - number_of_codes | ||
| - number_of_used_codes |
There was a problem hiding this comment.
the intention is to have those fields as optional, and we can query them in adhoc with "include" parameter, somethingg like "GET /promotions?include=number_of_codes,number_of_used_codes"
There was a problem hiding this comment.
@matt-evangelidis, atm we do have ?include=codes for our internal API usage right ?
There was a problem hiding this comment.
probably we can do the same for those number_of_codes and number_of_used_codes, make it available for internal usage for now ?
There was a problem hiding this comment.
if so, probably we don't need to update this swagger doc.
There was a problem hiding this comment.
i will implement as GET /promotions?include=number_of_codes,number_of_used_codes then
do we want to hide if promotion is automatic or maybe number of codes are 0 for automatic promotions?
There was a problem hiding this comment.
probably we can return 0 for automatic promotions, similar to how we are handling the codes and multiple_codes ?
There was a problem hiding this comment.
thanks ! @donald-nguyen-bc ill try with that in my implementation 👍
PROMO-1393
What changed?
add new field when get promotions
number_of_codes and number_of_used_codes
Release notes draft
Anything else?
ping {names}