Conversation
stas00
commented
Nov 19, 2021
Comment on lines
+320
to
+329
| launcher = get_launcher(1) | ||
| cmd = launcher + cmd_no_launcher | ||
| # keep for quick debug | ||
| # print(" ".join([f"\nPYTHONPATH={self.src_dir_str}"] +cmd)); die | ||
| execute_subprocess_async(cmd, env=self.get_env()) | ||
|
|
||
| # 2. DP=2 TP=1 PP=1 num_gpus=2 resume from the checkpoint of DP=1 | ||
| launcher = get_launcher(2) | ||
| cmd = launcher + cmd_no_launcher | ||
| execute_subprocess_async(cmd, env=self.get_env()) |
Contributor
Author
There was a problem hiding this comment.
Tim, the test is just this part.
adammoody
pushed a commit
to adammoody/Megatron-DeepSpeed
that referenced
this pull request
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a new test to reproduce the issue with BNB when switching from 1 replica to 2 (i.e. DP degree changes, while keeping PP and TP degrees the same):
the original error is here:
That was when moving from 128 gpus to 256 gpus. But actually the test that only moves from 1 gpu to 2 gpus has the same error.
@TimDettmers, to run the test:
Now run the test:
Unfortunately Megatron wants to recompile its kernels on each num gpus changes, so this test takes 10min to finish as it takes forever to build the kernels.
Now despite me using just 1 and 2 gpus, I get the same error as when I moved from 128 to 256 gpus. Therefore this error is not related to the actual number of GPUs directly, but the correlation is only to the multiplier so 2x here.
the CI is failing on this test.