Add switches

[gerard33]

• Climate (most logical use case in HA)
• Flash lights
• Horn

You can assign this one to me as well. I can rewrite my existing switches component to your bimmer connected module.

SWITCHES = {
    'climate': ['Climate', 'mdi:air-conditioner'],
    'light': ['Light', 'mdi:alarm-light'],
    'horn': ['Horn', 'mdi:bullhorn'],
}

[gerard33]

The following remote service can be added to remote_services.py.

CLIMATE = 'RCN'
HORN = 'RHB'

[gerard33]

@ChristianKuehnel
Allright, here is the first code for the switches.
Can you please check? Most important part is howto import the remote_service script.
So the code below is showing the switches, but not working yet :)

Show code

"""
Support for BMW cars with BMW ConnectedDrive.

For more details about this component, please refer to the documentation at
https://home-assistant.io/components/switch.bmw_connected_drive/
"""
import logging
import asyncio
import time

from custom_components.bmw_connected_drive import DOMAIN as BMW_DOMAIN
# from homeassistant.components.bmw_connected_drive import DOMAIN as BMW_DOMAIN
# from custom_components.bmw_connected_drive.remote_services import(
#     RemoteServiceStatus, ExecutionState)
# from homeassistant.components.bmw_connected_drive.remote_services import(
#     RemoteServiceStatus, ExecutionState)
from homeassistant.components.switch import ENTITY_ID_FORMAT, SwitchDevice
from homeassistant.const import STATE_OFF, STATE_ON

DEPENDENCIES = ['bmw_connected_drive']

_LOGGER = logging.getLogger(__name__)

SWITCHES = {
    'climate': ['Climate', 'mdi:air-conditioner'],
    'light': ['Light', 'mdi:alarm-light'],
    'horn': ['Horn', 'mdi:bullhorn']
    #'refresh': ['Refresh data', 'mdi:refresh']
}

def setup_platform(hass, config, add_devices, discovery_info=None):
    """Setup the BMW Connected Drive switches."""
    accounts = hass.data[BMW_DOMAIN]
    _LOGGER.debug('Found BMW accounts: %s',
                  ', '.join([a.name for a in accounts]))
    devices = []
    for account in accounts:
        for vehicle in account.account.vehicles:
            for key, value in sorted(SWITCHES.items()):
                device = BMWLock(account, vehicle, key, value[0], value[1])
                devices.append(device)
    add_devices(devices)

class BMWLock(SwitchDevice):
    """Representation of a BMW vehicle switch."""

    def __init__(self, account, vehicle, attribute: str, sensor_name, icon):
        """Initialize the switch."""
        self._account = account
        self._vehicle = vehicle
        self._attribute = attribute
        self._name = sensor_name
        self._icon = icon
        self._state = None

    @property
    def name(self):
        """Return the name of the switch."""
        return self._name

    @property
    def icon(self):
        """Icon to use in the frontend, if any."""
        return self._icon

    @property
    def is_on(self):
        """Get whether the switch is in on state."""
        return self._state == STATE_ON

    @property
    def device_state_attributes(self):
        """Return the state attributes of the switch."""
        vehicle_state = self._vehicle.state
        return {
            'last_update': vehicle_state.timestamp,
            'car': self._vehicle.modelName
        }

    def turn_on(self, **kwargs):
        """Send the on command."""
        _LOGGER.warning("%s: switching on %s", self._vehicle.modelName,
                        self._name)   ###info
        if self._attribute == 'light':
            status = self._vehicle.remote_services.light()
            while status.state != ExecutionState.EXECUTED:
                status = self._vehicle.remote_services.\
                         get_remote_service_status()
                time.sleep(1) # use time.sleep() or something else?
        ### Add climate and horn

    def turn_off(self, **kwargs):
        """Send the off command."""
        _LOGGER.warning("%s: switching off %s", self._vehicle.modelName,
                        self._name)   ###info
        ### CAN CLIMATE BE PUT OFF?

    def update(self):
        """Update state of the switch."""
        _LOGGER.info("%s: updating data for %s", self._vehicle.modelName,
                     self._attribute)

        ### IS CLIMATE STATUS AVAILABLE?
        self._state = STATE_OFF
        
        self.schedule_update_ha_state()

    @asyncio.coroutine
    def async_added_to_hass(self):
        """Add callback after being added to hass.
        Show latest data after startup.
        """
        self._account.add_update_listener(self.update)
        yield from self.hass.async_add_job(self.update)

[gerard33]

And a screenshot including the lock #19.

[ChristianKuehnel]

I just added air contidioning and horn in the latest PR: #29

[gerard33]

I have added the switches in a custom component over here.

Can you review this script?

[ChristianKuehnel]

I cant comment on the file in your repo. So I'll write is as a comment.

Things I noticed:

• The class should have a differnt name than BMWLock, maybe BMWSwitch.
• does it make sense to add that as a SwitchDevice shouldn't this be a service that can be triggered e.g. from an automation?
• Since this does not have a state: you do not need update() and async_added_to_hass()

[gerard33]

The class should have a differnt name than BMWLock, maybe BMWSwitch.

Oops... will indeed change that.

does it make sense to add that as a SwitchDevice shouldn't this be a service that can be triggered e.g. from an automation?

A switch might indeed be a bit strange, as you only need a button to activate it as it indeed doesn't have a state. Can you point me to some more info on the service?
I have found this but that's still an on and of button.

Since this does not have a state: you do not need update() and async_added_to_hass()

I still want to check if the status of the climate is visible.
If not, then I will remove these parts.

[ChristianKuehnel]

A service is basically a function call that can be triggered from an automation or a script.

Here is an example of how to create a service:
https://github.com/home-assistant/home-assistant/blob/678f284015a2c52f96a7687979cfd9f785e4527a/homeassistant/components/climate/__init__.py#L267-L269

And here is the documentation for these services:
https://github.com/home-assistant/home-assistant/blob/678f284015a2c52f96a7687979cfd9f785e4527a/homeassistant/components/climate/services.yaml

[m1n3rva]

looks like this is all done...

[gerard33]

Can you reopen this one?
The code is there, but still needs to be changed to make it a service as Christian suggested.
After that it can be added as a PR in HA.