Skip to content

BIP 197: Hashed Time-Locked Collateral Contract#773

Merged
luke-jr merged 3 commits intobitcoin:masterfrom
AtomicLoans:htlcc
Mar 29, 2019
Merged

BIP 197: Hashed Time-Locked Collateral Contract#773
luke-jr merged 3 commits intobitcoin:masterfrom
AtomicLoans:htlcc

Conversation

@matthewjablack
Copy link
Copy Markdown
Contributor

@matthewjablack matthewjablack commented Mar 27, 2019

Hello all,

This proposal went through the mailing list: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016805.html without any further discussion. Currently this proposal has been implemented by in the ChainAbstractionLayer (https://github.com/liquality/chainabstractionlayer/tree/dev). I would like to kindly ask for BIP # assignment and have this merged into upstream bips.

Cheers,

Matthew Black

@matthewjablack matthewjablack changed the title BIP 200: Hashed Time-Locked Collateral Contract transactions BIP 200: Hashed Time-Locked Collateral Contract Mar 27, 2019
@matthewjablack matthewjablack changed the title BIP 200: Hashed Time-Locked Collateral Contract BIP ???: Hashed Time-Locked Collateral Contract Mar 27, 2019
@matthewjablack matthewjablack changed the title BIP ???: Hashed Time-Locked Collateral Contract BIP 200: Hashed Time-Locked Collateral Contract Mar 27, 2019
@luke-jr luke-jr changed the title BIP 200: Hashed Time-Locked Collateral Contract New BIP: Hashed Time-Locked Collateral Contract Mar 28, 2019
@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Mar 28, 2019

Never self-assign BIP numbers.

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Mar 28, 2019

(BIP 200 is already reserved for something else)

Comments-Summary: No comments yet.
Comments-URI: TBD
Status: Proposal
Type: Informational
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Standards Track

Atomic Loans team <info@atomicloans.io>
Comments-Summary: No comments yet.
Comments-URI: TBD
Status: Proposal
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Draft

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Mar 28, 2019

For a BIP number to be assigned, you must add a Backwards compatibility section.

@luke-jr luke-jr changed the title New BIP: Hashed Time-Locked Collateral Contract BIP 197: Hashed Time-Locked Collateral Contract Mar 29, 2019
@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Mar 29, 2019

Please use BIP number 197 (and purge the incorrect number from the git branch history)

@matthewjablack matthewjablack force-pushed the htlcc branch 8 times, most recently from 5eeb2d1 to 4809519 Compare March 29, 2019 16:46
Title: Hashed Time-Locked Collateral Contract
Author: Matthew Black <matthew@atomicloans.io>
Tony Cai <tony@atomicloans.io>
Atomic Loans team <info@atomicloans.io>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure teams can be authors; either way, this needs to match what's in README

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Atomic Loans team <info@atomicloans.io> from Author list

<pre>
BIP: 197
Layer: Applications
Title: Hashed Time-Locked Collateral Contract
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to match README

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed title in README for BIP 197 to Hashed Time-Locked Collateral Contract

@luke-jr luke-jr merged commit 49e38e2 into bitcoin:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants