fix(descriptor): correct index tracking in combinations() function#453
Open
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix(descriptor): correct index tracking in combinations() function#453tnull wants to merge 1 commit intobitcoindevkit:masterfrom
combinations() function#453tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
tnull
force-pushed
the
2026-04-fix-combinations-index-bug
branch
from
2012f7c to
0dd6d08
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 24 24
Lines 5360 5360
Branches 244 244
=======================================
Hits 4291 4291
Misses 990 990
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The combinations function was pushing `new_index` (the enumerate index relative to the skipped iterator) instead of `index + 1 + new_index` (the absolute index in the original vec). This caused duplicate and incorrect combinations to be generated for inputs larger than trivial sizes. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
ValuedMammal
force-pushed
the
2026-04-fix-combinations-index-bug
branch
from
0dd6d08 to
d6bbe77
Compare
Collaborator
|
Rebased |
ValuedMammal
approved these changes
May 1, 2026
Collaborator
ValuedMammal
left a comment
ValuedMammal
left a comment
There was a problem hiding this comment.
ACK d6bbe77; ran the tests locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The combinations function was pushing
new_index(the enumerate index relative to the skipped iterator) instead ofindex + 1 + new_index(the absolute index in the original vec). This caused duplicate and incorrect combinations to be generated for inputs larger than trivial sizes.Checklists
All Submissions:
just pbefore pushingBugfixes: