Update to dotnet 10.0.1 (#11859) #11860
Conversation
WalkthroughThe pull request updates the .NET SDK and related NuGet package versions across the codebase. The SDK version is incremented from 10.0.100 to 10.0.101 in devcontainer configurations, global.json, and documentation. Multiple NuGet packages are bumped from 10.0.0 to 10.0.1, with AI-related packages updated to 10.1.0. Minor XML escaping corrections are applied to MSBuild targets in several project files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (29)
.devcontainer/devcontainer.json(1 hunks)docs/how-to-build.md(1 hunks)src/Besql/Demo/Bit.Besql.Demo.Client/Bit.Besql.Demo.Client.csproj(1 hunks)src/Besql/Demo/Bit.Besql.Demo/Bit.Besql.Demo.csproj(2 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj(2 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj(1 hunks)src/Bswup/Bit.Bswup.Demo/Bit.Bswup.Demo.csproj(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/Bit.Bswup.NewDemo.Client.csproj(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.csproj(1 hunks)src/Bswup/FullDemo/Client/Bit.Bswup.Demo.Client.csproj(1 hunks)src/Bswup/FullDemo/Server/Bit.Bswup.Demo.Server.csproj(1 hunks)src/Butil/Demo/Bit.Butil.Demo.Maui/Bit.Butil.Demo.Maui.csproj(1 hunks)src/Butil/Demo/Bit.Butil.Demo.Web/Bit.Butil.Demo.Web.csproj(1 hunks)src/ResxTranslator/Bit.ResxTranslator/Bit.ResxTranslator.csproj(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/.devcontainer/devcontainer.json(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props(6 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj(3 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj(3 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj(3 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj(1 hunks)src/global.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: bit platform CI - Bswup
src/Bswup/Bit.Bswup.Demo/Bit.Bswup.Demo.csproj
[error] 1-1: The target 'InstallNodejsDependencies' does not exist in the project. (dotnet build)
src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.csproj
[error] 1-1: The target 'InstallNodejsDependencies' does not exist in the project. (dotnet build)
src/Bswup/FullDemo/Client/Bit.Bswup.Demo.Client.csproj
[error] 1-1: The target 'InstallNodejsDependencies' does not exist in the project. (dotnet build)
src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/Bit.Bswup.NewDemo.Client.csproj
[error] 1-1: The target 'InstallNodejsDependencies' does not exist in the project. (dotnet build)
[error] 1-1: The target 'InstallNodejsDependencies' does not exist in the project. (dotnet build)
src/Bswup/FullDemo/Server/Bit.Bswup.Demo.Server.csproj
[error] 1-1: The target 'InstallNodejsDependencies' does not exist in the project. (dotnet build)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build Bit.Templates
- GitHub Check: build Bit.BlazorUI
- GitHub Check: build Bit.Butil
🔇 Additional comments (33)
src/Butil/Demo/Bit.Butil.Demo.Maui/Bit.Butil.Demo.Maui.csproj (1)
55-55: Update looks good.The patch-level version bump for
Microsoft.Extensions.Logging.Debugfrom 10.0.0 to 10.0.1 aligns with the PR objective and is backward compatible.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)
42-42: Version bump looks good and aligns with PR objectives.The update of
Microsoft.AspNetCore.Components.Webfrom 10.0.0 to 10.0.1 is a straightforward patch-level update that is consistent with the PR's goal to update NuGet packages to 10.0.1.Please verify that this version is compatible with the related
Microsoft.AspNetCore.Components.WebView.WindowsFormspackage at version 10.0.11. While they're from the same framework family, ensuring version alignment across related Blazor/ASP.NET Core packages helps prevent subtle runtime issues.src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/Bit.Bswup.NewDemo.Client.csproj (1)
16-16: Package version bump is aligned with PR objective, but pipeline failure requires attention.The version bump from 10.0.0 to 10.0.1 for
Microsoft.AspNetCore.Components.WebAssemblyis appropriate and consistent with the .NET 10.0.1 update goal. However, the dotnet build is failing with an error about a missingInstallNodejsDependenciestarget at the project root level (line 1-1), which is unrelated to this specific change.This failure suggests either:
- A pre-existing issue in the build infrastructure unrelated to these version updates
- A missing or misconfigured MSBuild target elsewhere in the PR (the AI summary mentions XML escaping corrections in MSBuild targets, which are not visible in these two files)
Can you verify whether the
InstallNodejsDependenciestarget is defined in any parent or imported MSBuild files, or if this is a known pre-existing build issue?src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.csproj (1)
11-11: Package version bump is appropriate and coordinated with client-side update.The version bump from 10.0.0 to 10.0.1 for
Microsoft.AspNetCore.Components.WebAssembly.Serveris correct and complements the corresponding client-side package update inBit.Bswup.NewDemo.Client.csproj. This patch-level bump is non-breaking.However, the same
InstallNodejsDependenciesbuild target error reported for the client project also applies here.The pipeline failure at line 1-1 appears to be systemic across both projects. Please investigate whether this is introduced by changes elsewhere in the PR (the AI summary mentions MSBuild target modifications not visible in these two files) or if it's a pre-existing infrastructure issue.
src/Bswup/FullDemo/Client/Bit.Bswup.Demo.Client.csproj (1)
12-13: Package version updates appear correct, but build failure requires verification.The version bumps from 10.0.0 to 10.0.1 are appropriately applied to both AspNetCore.Components packages, maintaining alignment. However, a pipeline build failure is reported: "The target 'InstallNodejsDependencies' does not exist in the project."
This build target error is blocking the entire build process. The target may be:
- Imported from a shared targets file or the referenced
Bit.Bswup.csproj- Missing due to incomplete MSBuild configuration
- Broken by recent build-system changes
Investigate the build failure and verify that the
InstallNodejsDependenciestarget is properly defined and available across the project system.src/Butil/Demo/Bit.Butil.Demo.Web/Bit.Butil.Demo.Web.csproj (1)
10-11: Verify consistency across related Blazor WebAssembly projects.The patch version bump from 10.0.0 to 10.0.1 for Microsoft.AspNetCore.Components.WebAssembly packages is a safe, backward-compatible update. Ensure all related Blazor WebAssembly projects in the codebase are updated consistently to 10.0.1.
src/Templates/Boilerplate/Bit.Boilerplate/.devcontainer/devcontainer.json (1)
3-3: LGTM!The SDK version bump to 10.0.101 is straightforward and aligns with the global.json and other devcontainer updates.
.devcontainer/devcontainer.json (1)
17-17: LGTM!The SDK version update is consistent with the global.json and Boilerplate devcontainer changes.
src/global.json (1)
3-3: LGTM!The SDK version is correctly updated, and the
rollForward: disablesetting ensures consistent tooling across the repository.docs/how-to-build.md (1)
25-25: LGTM!The documentation correctly reflects the new SDK version requirement.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (2)
27-30: LGTM!Package version bumps from 10.0.0 to 10.0.1 are consistent with the PR scope and align with the SDK upgrade to 10.0.101.
91-91: MSBuild should correctly parse the XML-escaped>character in the Outputs attribute.The
>entity reference in@(IsolatedScssFiles->Replace('.scss', '.css'))will be automatically decoded to>by the XML parser when MSBuild reads the .csproj file, as per the XML specification. However, verify that the SCSS build target executes correctly and check if this escaping pattern is consistent with other similar targets in the project file.src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1)
17-19: LGTM!Package version bumps to 10.0.1 are consistent and properly applied to shared library dependencies.
src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)
23-25: LGTM!Package version bumps to 10.0.1 are correctly applied to Blazor/ASP.NET Core server dependencies.
src/Besql/Demo/Bit.Besql.Demo/Bit.Besql.Demo.csproj (1)
11-11: LGTM!Package version bumps to 10.0.1 are correctly applied, including EF Core tooling and Blazor server packages.
Also applies to: 20-20, 24-24
src/Besql/Demo/Bit.Besql.Demo.Client/Bit.Besql.Demo.Client.csproj (1)
13-13: LGTM - Package version update aligns with SDK upgrade.The bump to 10.0.1 is a patch release that aligns with the SDK update to 10.0.101.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)
102-102: LGTM - Documentation updated to reference the latest SDK.The SDK download URL correctly references version 10.0.101, which has been released.
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1)
16-19: LGTM - Microsoft.Extensions package updates.All four packages updated to 10.0.1 are patch releases that should be backward compatible.
src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)
23-25: LGTM - ASP.NET Core Blazor package updates.The WebAssembly and Components packages are updated to 10.0.1, consistent with the SDK upgrade.
src/ResxTranslator/Bit.ResxTranslator/Bit.ResxTranslator.csproj (1)
17-23: LGTM - AI and Extensions package updates.The AI packages are updated to 10.1.0 (minor version bump), while the Extensions packages receive patch updates to 10.0.1. Minor version bumps typically add features without breaking changes.
src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1)
24-28: LGTM - AI and ASP.NET Core package updates.The updates are consistent with the PR's overall dependency upgrade strategy: AI packages to 10.1.0 and ASP.NET Core packages to 10.0.1.
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1)
24-24: LGTM - AI and WebAssembly package updates.Package versions are updated consistently with the rest of the PR.
Also applies to: 32-33
src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1)
17-19: LGTM - Microsoft.Extensions package updates.These patch updates to 10.0.1 maintain consistency across the codebase.
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (2)
23-23: Package version bumps look good.The updates from 10.0.0 to 10.0.1 for
Microsoft.AspNetCore.Components.WebAssemblyandMicrosoft.AspNetCore.Components.Webalign with the PR objective.Also applies to: 44-44
97-97: XML escaping change is technically optional but harmless.The
>character doesn't require escaping in XML attribute values (only<,&, and quote delimiters must be escaped). The unescaped form->was valid XML. However, using>is also valid and may improve compatibility with certain XML parsers or tools.If this change addresses a specific MSBuild or tooling issue, consider adding a brief comment explaining why the escaping is necessary.
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1)
23-23: Changes are consistent with other client projects.The package updates and XML escaping change mirror the changes in
Bit.Websites.Careers.Client.csproj, maintaining consistency across the codebase.Also applies to: 44-44, 97-97
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1)
26-26: Package updates and XML escaping change are consistent.All three ASP.NET Core packages are correctly bumped to 10.0.1, including the additional
Microsoft.AspNetCore.SignalR.Clientdependency specific to this project.Also applies to: 48-49, 102-102
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2)
95-96: Note: Mixed preview versions for AI packages.
Microsoft.Extensions.AI.OpenAIis updated to10.1.0-preview.1.25608.1, whileMicrosoft.Extensions.AI.AzureAIInferenceremains at10.0.0-preview.1.25559.3. Verify if the AzureAIInference package should also be updated for consistency, or if the current version is intentional due to compatibility requirements.
19-26: Central package management updates are well-organized and consistent.The version bumps follow a coherent pattern:
- ASP.NET Core packages → 10.0.1
- EF Core packages → 10.0.1
- Microsoft.Extensions packages → 10.0.1 / 10.1.0
- Third-party packages (Scalar.AspNetCore 2.11.3, EmbedIO 3.5.2, Magick.NET 14.10.0)
These versions align with .NET 10's release cycle. Note the use of preview versions for AI packages (Microsoft.Extensions.AI.OpenAI 10.1.0-preview, AI.AzureAIInference 10.0.0-preview), which is appropriate for emerging AI tooling in the framework.
src/Bswup/FullDemo/Server/Bit.Bswup.Demo.Server.csproj (2)
11-11: Package version update is correct.The bump to
Microsoft.AspNetCore.Components.WebAssembly.Serverversion 10.0.1 aligns with the coordinated dependency updates across the codebase and is compatible with the net10.0 target framework.
1-14: Verify the build error context and which project fails.The
InstallNodejsDependenciestarget is provided by the Blazor WebAssembly build system through theMicrosoft.AspNetCore.Components.WebAssemblypackage and should not require manual definition. Before treating this as a critical issue, confirm:
- Which project actually fails to build (server, client, or both)?
- What is the exact error message from the build pipeline?
- Does the client project have the correct package reference?
- Does the error persist after a clean restore (
dotnet clean && dotnet restore)?src/Bswup/Bit.Bswup.Demo/Bit.Bswup.Demo.csproj (2)
11-12: Version bumps are structurally correct (pending build fix).The NuGet package version updates from 10.0.0 to 10.0.1 for
Microsoft.AspNetCore.Components.WebAssemblyandDevServerare correctly formatted and align with the PR objectives. However, this change cannot be validated as working until the build failure is resolved.Ensure the build passes once the missing target issue is diagnosed and fixed.
1-23: The 'InstallNodejsDependencies' target is not provided by the .NET 10 Blazor WebAssembly SDK and must be explicitly defined if Node.js dependencies need to be installed during the build..NET 10 removed the built-in
InstallNodejsDependenciestarget that was available in earlier versions. If this project requires npm/yarn/pnpm to manage JavaScript or TypeScript dependencies, add this target to the.csprojfile:<Target Name="InstallNodejsDependencies" BeforeBuild="true" Inputs="package.json" Outputs="node_modules\.package-lock.json"> <Exec Command="npm install" /> </Target>Clarify whether the project needs this target based on its actual JavaScript/TypeScript build requirements before deciding if it should be added.
src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
Show resolved
Hide resolved
1 participant
closes #11859
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.