Skip to content

[PM-33941] llm: Refine skills and commands for agent reliability#6703

Open
SaintPatrck wants to merge 2 commits intomainfrom
llm/skill-refinements
Open

[PM-33941] llm: Refine skills and commands for agent reliability#6703
SaintPatrck wants to merge 2 commits intomainfrom
llm/skill-refinements

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33941

📔 Objective

Improves Claude Code skill and command reliability for agent-driven development:

  • work-on-android.md: Use Skill() invocation syntax so agents trigger skills correctly instead of treating references as prose
  • build-test-verify/SKILL.md: Add detekt -Pprecommit=true flag guidance and output grep filtering to capture violations on the first run
  • testing-android-code/SKILL.md: Promote @Suppress("MaxLineLength") rule from a buried bullet to a prominent blockquote warning, preventing agents from reflexively copying the annotation without verifying line length

- work-on-android: Use Skill() invocation syntax so agents
  trigger skills correctly instead of treating them as prose
- build-test-verify: Add detekt precommit flag guidance and
  output filtering to capture violations on first run
- testing-android-code: Promote @Suppress("MaxLineLength")
  rule from buried bullet to prominent stop-warning to prevent
  agents from copying the annotation without verifying line length
@github-actions github-actions bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.63%. Comparing base (988a321) to head (9e9d8a4).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6703      +/-   ##
==========================================
- Coverage   85.67%   85.63%   -0.04%     
==========================================
  Files         852      926      +74     
  Lines       59107    60201    +1094     
  Branches     8435     8519      +84     
==========================================
+ Hits        50641    51555     +914     
- Misses       5524     5683     +159     
- Partials     2942     2963      +21     
Flag Coverage Δ
app-data 17.68% <ø> (+0.29%) ⬆️
app-ui-auth-tools 20.89% <ø> (+0.13%) ⬆️
app-ui-platform 15.58% <ø> (-0.07%) ⬇️
app-ui-vault 26.86% <ø> (+0.35%) ⬆️
authenticator 6.54% <ø> (-0.08%) ⬇️
lib-core-network-bridge 4.25% <ø> (-0.02%) ⬇️
lib-data-ui 0.94% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck requested review from a team and david-livefront March 20, 2026 16:34
@SaintPatrck SaintPatrck marked this pull request as ready for review March 20, 2026 16:34
@SaintPatrck SaintPatrck requested a review from a team as a code owner March 20, 2026 16:34
@SaintPatrck SaintPatrck added the ai-review Request a Claude code review label Mar 20, 2026
@claude
Copy link
Contributor

claude bot commented Mar 20, 2026

Claude finished @SaintPatrck's task in 1m 27s —— View job


Code Review Complete

  • Gather context and read changed files
  • Review changes against Bitwarden standards
  • Post review findings

Summary

Reviewed all 3 changed files. No new actionable findings — the previous review's suggestions (article consistency in work-on-android.md and git add -A scope in build-test-verify/SKILL.md) are still the only notable items, and both are marked as outdated after the latest push addressing code review feedback.

The changes are well-scoped and improve agent reliability:

  • Skill() invocation syntax in work-on-android.md ensures agents trigger skills correctly
  • Detekt -Pprecommit=true flag guidance with grep filtering in build-test-verify/SKILL.md captures violations on first run
  • Promoted @Suppress("MaxLineLength") warning in testing-android-code/SKILL.md prevents agents from reflexively copying the annotation

No blocking issues.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Logo
Checkmarx One – Scan Summary & Details25857af1-4aca-42f0-a7d2-a6ebc3a74e37


Fixed Issues (1) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM Use_of_Hardcoded_Password /app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt: 147

Fix inconsistent Invoke phrasing in work-on-android command
and replace git add -A with git add -u in detekt command to
avoid staging unintended files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant