chore: Update RootNavScreen to enforce state-based navigation#6713
chore: Update RootNavScreen to enforce state-based navigation#6713david-livefront merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6713 +/- ##
==========================================
+ Coverage 85.30% 85.54% +0.24%
==========================================
Files 897 890 -7
Lines 59830 59810 -20
Branches 8504 8505 +1
==========================================
+ Hits 51037 51166 +129
+ Misses 5840 5689 -151
- Partials 2953 2955 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Claude finished @david-livefront's task in 57s —— View job Re-review: PR #6713
SummaryVerified that the KDoc issue from the previous review has been fixed — line 26 of Re-reviewed all 5 changed files. No new issues found. The PR cleanly enforces state-based navigation in
LGTM — looks good to merge. |
...src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/resetpassword/ResetPasswordNavigation.kt
Outdated
Show resolved
Hide resolved
10da81f to
e412211
Compare
|
Thanks @SaintPatrck |

🎟️ Tracking
N/A
📔 Objective
This PR cleans up a small bit of code where we were mixing event-based navigation into the
RootNavScreenwhere only state-based navigation should be allowed.