Skip to content

chore: Update RootNavScreen to enforce state-based navigation#6713

Merged
david-livefront merged 1 commit intomainfrom
clean-up-root-nav
Mar 25, 2026
Merged

chore: Update RootNavScreen to enforce state-based navigation#6713
david-livefront merged 1 commit intomainfrom
clean-up-root-nav

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR cleans up a small bit of code where we were mixing event-based navigation into the RootNavScreen where only state-based navigation should be allowed.

@david-livefront david-livefront requested a review from a team as a code owner March 24, 2026 20:25
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt labels Mar 24, 2026
@david-livefront david-livefront added the ai-review Request a Claude code review label Mar 24, 2026
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.54%. Comparing base (b4917ce) to head (e412211).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...taccountlockout/PreventAccountLockoutNavigation.kt 38.46% 8 Missing ⚠️
...arden/ui/platform/feature/rootnav/RootNavScreen.kt 42.85% 4 Missing ⚠️
...t/bitwarden/ui/auth/feature/auth/AuthNavigation.kt 33.33% 2 Missing ⚠️
...h/feature/resetpassword/ResetPasswordNavigation.kt 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6713      +/-   ##
==========================================
+ Coverage   85.30%   85.54%   +0.24%     
==========================================
  Files         897      890       -7     
  Lines       59830    59810      -20     
  Branches     8504     8505       +1     
==========================================
+ Hits        51037    51166     +129     
+ Misses       5840     5689     -151     
- Partials     2953     2955       +2     
Flag Coverage Δ
app-data 17.34% <0.00%> (-0.16%) ⬇️
app-ui-auth-tools 20.81% <0.00%> (+<0.01%) ⬆️
app-ui-platform 15.38% <50.00%> (+0.06%) ⬆️
app-ui-vault 26.91% <0.00%> (+0.13%) ⬆️
authenticator 6.55% <0.00%> (-0.02%) ⬇️
lib-core-network-bridge 4.23% <0.00%> (+<0.01%) ⬆️
lib-data-ui 0.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

Logo
Checkmarx One – Scan Summary & Details143aee37-61d3-45a2-a795-87c2d58456ac

Great job! No new security vulnerabilities introduced in this pull request

@claude
Copy link
Contributor

claude bot commented Mar 24, 2026

Claude finished @david-livefront's task in 57s —— View job


Re-review: PR #6713

  • Check previous review findings
  • Verify KDoc fix in ResetPasswordNavigation.kt
  • Review full diff for any new issues

Summary

Verified that the KDoc issue from the previous review has been fixed — line 26 of ResetPasswordNavigation.kt now correctly reads Add password reset destinations to the nav graph. instead of referencing trusted device.

Re-reviewed all 5 changed files. No new issues found. The PR cleanly enforces state-based navigation in RootNavScreen by:

  • Extracting preventAccountLockout and resetPassword event-based navigation out of root nav
  • Introducing PreventAccountLockoutRoute sealed class with Standard/PasswordReset subtypes to register the same screen in multiple nav graphs
  • Creating a passwordResetGraph that encapsulates both the reset password screen and its prevent-account-lockout destination

LGTM — looks good to merge.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 6332081 Mar 25, 2026
35 checks passed
@david-livefront david-livefront deleted the clean-up-root-nav branch March 25, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants