[PM-34125] feat: Add card text analysis pipeline#6720
[PM-34125] feat: Add card text analysis pipeline#6720SaintPatrck wants to merge 1 commit intocard-scanner/1-generalize-camera-previewfrom
Conversation
|
Overall Assessment: APPROVE This PR adds the complete text analysis pipeline for credit card scanning. Changes include Luhn validation and card number sanitization utilities, a regex-based OCR data parser for extracting card details, ML Kit Text Recognition integration for camera frame analysis, a card scan overlay composable, and card brand detection. The implementation correctly follows the existing Code Review DetailsNo findings. The code is well-structured, follows established codebase conventions (interface/impl pairs, |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## card-scanner/1-generalize-camera-preview #6720 +/- ##
============================================================================
- Coverage 85.72% 85.65% -0.07%
============================================================================
Files 944 950 +6
Lines 60660 60493 -167
Branches 8566 8592 +26
============================================================================
- Hits 51998 51813 -185
+ Misses 5682 5673 -9
- Partials 2980 3007 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
Add the complete text analysis pipeline for credit card scanning: - CardNumberUtils: sanitize, Luhn validation, brand detection - CardDataParser: interface and implementation for OCR text parsing - CardTextAnalyzer: ML Kit-based camera frame analysis - CardScanOverlay: camera overlay composable - CardScanData: data class for parsed card fields - FakeCardTextAnalyzer: test fixture - LocalProviders: composition local for CardTextAnalyzer
2333a61 to
d776756
Compare

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34125
📔 Objective
Add the complete text analysis pipeline for credit card scanning:
detectCardBrand) usingVaultCardBrandIncludes full test coverage for parser logic, Luhn validation, and sanitization.